FIX: set the Host header on the upstream block
#900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using e.g. `proxy_pass http://discourse` resets the Host header on the upstream request to `discourse`. This would break multisites, so we don't want that; the most effetive way to ensure it's set properly is to `set_header` in the upstream block.
Supermathie
force-pushed
the
set_host_on_upstream
branch
from
c3ffdd0 to
f85e613
Compare
Supermathie
added a commit
to discourse/discourse
that referenced
this pull request
Dec 19, 2024
Using e.g. `proxy_pass http://discourse` resets the Host header on the upstream request to `discourse`. This would break multisites, so we don't want that; the most effetive way to ensure it's set properly is to `set_header` in the upstream block. See also: discourse/discourse_docker#900
Supermathie
added a commit
to discourse/discourse
that referenced
this pull request
Dec 19, 2024
Using e.g. `proxy_pass http://discourse` resets the Host header on the upstream request to `discourse`. This would break multisites, so we don't want that; the most effetive way to ensure it's set properly is to `set_header` in the upstream block. See also: discourse/discourse_docker#900
davidtaylorhq
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using e.g.
proxy_pass http://discourseresets the Host header on the upstreamrequest to
discourse.This would break multisites, so we don't want that; the most effetive way to
ensure it's set properly is to
set_headerin the upstream block.